redmine_plugins/redmine_dmsf
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ERB::Util#h

Browse Source 
The method ERB::Util#h is an alias for ERB::Util#html_escape. It is
applied on a user name whithin a collect condition in DmsfUploadHelper module.

This implementation was also applied in other modules and has
caused HTML status 500 errors wherefore it was removed.

Therefore, it should also precautionary eliminated in DmsfUploadHelper module.
This commit is contained in:
Liane Hampe 2021-08-28 17:36:52 +02:00
parent a5bca770dc
commit 5712d4707a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/helpers/dmsf_upload_helper.rb
View File

@ -152,7 +152,7 @@ module DmsfUploadHelper
recipients = DmsfMailer.deliver_files_updated(project, files)
if Setting.plugin_redmine_dmsf['dmsf_display_notified_recipients']
unless recipients.empty?
to = recipients.collect{ |r| h(r.name) }.first(DMSF_MAX_NOTIFICATION_RECEIVERS_INFO).join(', ')
to = recipients.collect{ |r| r.name }.first(DMSF_MAX_NOTIFICATION_RECEIVERS_INFO).join(', ')
to << ((recipients.count > DMSF_MAX_NOTIFICATION_RECEIVERS_INFO) ? ',...' : '.')
controller.flash[:warning] = l(:warning_email_notifications, to: to) if controller
end