From 5712d4707a52b6b977c05c5a37549c24275f0809 Mon Sep 17 00:00:00 2001 From: Liane Hampe Date: Sat, 28 Aug 2021 17:36:52 +0200 Subject: [PATCH] Remove ERB::Util#h The method ERB::Util#h is an alias for ERB::Util#html_escape. It is applied on a user name whithin a collect condition in DmsfUploadHelper module. This implementation was also applied in other modules and has caused HTML status 500 errors wherefore it was removed. Therefore, it should also precautionary eliminated in DmsfUploadHelper module. --- app/helpers/dmsf_upload_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/dmsf_upload_helper.rb b/app/helpers/dmsf_upload_helper.rb index aacc8f98..f29267ba 100644 --- a/app/helpers/dmsf_upload_helper.rb +++ b/app/helpers/dmsf_upload_helper.rb @@ -152,7 +152,7 @@ module DmsfUploadHelper recipients = DmsfMailer.deliver_files_updated(project, files) if Setting.plugin_redmine_dmsf['dmsf_display_notified_recipients'] unless recipients.empty? - to = recipients.collect{ |r| h(r.name) }.first(DMSF_MAX_NOTIFICATION_RECEIVERS_INFO).join(', ') + to = recipients.collect{ |r| r.name }.first(DMSF_MAX_NOTIFICATION_RECEIVERS_INFO).join(', ') to << ((recipients.count > DMSF_MAX_NOTIFICATION_RECEIVERS_INFO) ? ',...' : '.') controller.flash[:warning] = l(:warning_email_notifications, to: to) if controller end