small syntax refactorings

modifié :         lib/details_issue_hooks.rb
This commit is contained in:
Lxc 2019-09-25 22:27:03 +02:00
parent 0b2ba88f71
commit 693f60ce1b

View File

@ -1,203 +1,210 @@
class DetailsIssueHooks < Redmine::Hook::ViewListener class DetailsIssueHooks < Redmine::Hook::ViewListener
def protect_against_forgery? def protect_against_forgery?
false false
end
def current_is_detail_page(context)
# check if we see an issue but not creating a new one or on the specific edit page
ret = context[:controller] && context[:controller].is_a?(IssuesController) && context[:request].original_url.rindex(/\/issues\/\S+/) && !context[:request].original_url.rindex(/\/issues\/new/) && !context[:request].original_url.rindex(/\/issues\/\d+\/edit/)
end
def view_layouts_base_html_head(context)
if current_is_detail_page(context)
stylesheet_link_tag('issue_dynamic_edit.css', :plugin => :redmine_issue_dynamic_edit)
end
end end
def view_layouts_base_body_bottom(context) def current_is_detail_page(context)
if current_is_detail_page(context) # check if we see an issue but not creating a new one or on the specific edit page
javascript_include_tag('issue_dynamic_edit_configuration_file.js', 'issue_dynamic_edit.js', :plugin => :redmine_issue_dynamic_edit) ret = context[:controller] && context[:controller].is_a?(IssuesController) && context[:request].original_url.rindex(/\/issues\/\S+/) && !context[:request].original_url.rindex(/\/issues\/new/) && !context[:request].original_url.rindex(/\/issues\/\d+\/edit/)
end
end end
def view_issues_show_details_bottom(context = { }) def view_layouts_base_html_head(context)
return unless current_is_detail_page(context)
stylesheet_link_tag('issue_dynamic_edit.css', :plugin => :redmine_issue_dynamic_edit)
end
def view_layouts_base_body_bottom(context)
return unless current_is_detail_page(context)
javascript_include_tag('issue_dynamic_edit_configuration_file.js', 'issue_dynamic_edit.js', :plugin => :redmine_issue_dynamic_edit)
end
def view_issues_show_details_bottom(context = {})
project = context[:project] project = context[:project]
request = context[:request] request = context[:request]
issue_id = request.path_parameters[:id] issue_id = request.path_parameters[:id]
back = request.env['HTTP_REFERER'] back = request.env['HTTP_REFERER']
o = '' o = ''
if (issue_id) if issue_id
issue = Issue.find(issue_id) issue = Issue.find(issue_id)
readOnlyAttributes = issue.read_only_attribute_names(User.current) readOnlyAttributes = issue.read_only_attribute_names(User.current)
requiredAttributes = issue.required_attribute_names(User.current) requiredAttributes = issue.required_attribute_names(User.current)
# o << requiredAttributes.to_json # o << requiredAttributes.to_json
allRequiredFieldsFilled = true allRequiredFieldsFilled = true
requiredAttributes.each do |attr| requiredAttributes.each do |attr|
if(issue.read_attribute(attr).to_s.empty?) if issue.read_attribute(attr).to_s.empty?
allRequiredFieldsFilled = false allRequiredFieldsFilled = false
end end
end end
if (issue) if issue
if (User.current.allowed_to?(:edit_issues, project)) if User.current.allowed_to?(:edit_issues, project)
# if there's a JS error, we hide the generated values
o << '<div style="display:none">'
# if there's a JS error, we hide the generated values # Status dropdown
o << '<div style="display:none">' statuses = issue.new_statuses_allowed_to(User.current)
if (
!statuses.empty? &&
!readOnlyAttributes.include?('status_id') &&
allRequiredFieldsFilled
)
o << "<span class='dynamicEdit' id='statusListDropdown'>"
o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
statuses.each do |s|
if (s != issue.status)
o << "<option value='#{s.id}'>#{s.name}</option>"
else
o << "<option value='#{s.id}' selected>#{s.name}</option>"
end
end
# Status dropdown o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
statuses = issue.new_statuses_allowed_to(User.current)
if (!statuses.empty? && !(readOnlyAttributes.include? 'status_id') && allRequiredFieldsFilled)
o << "<span class='dynamicEdit' id='statusListDropdown'>"
o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
statuses.each do |s|
if (s != issue.status)
o << "<option value='#{s.id}'>#{s.name}</option>"
else
o << "<option value='#{s.id}' selected>#{s.name}</option>"
end
end
o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
end end
# Users dropdown # Users dropdown
assignables = project.assignable_users assignables = project.assignable_users
if (!assignables.empty? && !(readOnlyAttributes.include? 'assigned_to_id')) if (
o << "<span class='dynamicEdit' id='usersListDropdown'>" !assignables.empty? &&
o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>" !readOnlyAttributes.include?('assigned_to_id')
assignables.each do |u| )
if (u != issue.assigned_to) o << "<span class='dynamicEdit' id='usersListDropdown'>"
o << "<option value='#{u.id}'>#{u.name}</option>" o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
else
o << "<option value='#{u.id}' selected>#{u.name}</option>" assignables.each do |u|
end if (u != issue.assigned_to)
end o << "<option value='#{u.id}'>#{u.name}</option>"
o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>" else
o << "<option value='#{u.id}' selected>#{u.name}</option>"
end
end
o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
end end
# Priorities dropdown # Priorities dropdown
priorities = IssuePriority.all priorities = IssuePriority.all
if(!priorities.empty? && !(readOnlyAttributes.include? 'priority_id'))
o << "<span class='dynamicEdit' id='prioritiesListDropdown'>"
o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
priorities.each do |p|
if (p != issue.priority)
o << "<option value='#{p.id}'>#{p.name}</option>"
else
o << "<option value='#{p.id}' selected>#{p.name}</option>"
end
end
o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
end
# %done dropdown if !priorities.empty? && !(readOnlyAttributes.include? 'priority_id')
if(!(readOnlyAttributes.include? 'done_ratio')) o << "<span class='dynamicEdit' id='prioritiesListDropdown'>"
percent = 0 o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
o << "<span class='dynamicEdit' id='doneRatioListDropdown'>"
o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
loop do
if (percent == issue.done_ratio)
o << "<option value='#{percent}' selected>#{percent}%</option>"
else
o << "<option value='#{percent}'>#{percent}%</option>"
end
percent += 10
if percent == 110
break
end
end
o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
end
# Estimated_time dropdown priorities.each do |p|
if(!(readOnlyAttributes.include? 'estimated_hours')) if (p != issue.priority)
o << "<span class='dynamicEdit' id='EstimatedTimeInput'>" o << "<option value='#{p.id}'>#{p.name}</option>"
o << " <input type='text' value='#{issue.estimated_hours}' size='6'/>" else
o << "<a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>" o << "<option value='#{p.id}' selected>#{p.name}</option>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>" end
o << "</span>" end
end
# Start date o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
if(!(readOnlyAttributes.include? 'start_date')) end
o << "<span class='dynamicEdit' id='StartDateInput'>"
o << " <input size=\"10\" value=\"#{issue.start_date}\" type=\"date\" max=\"#{issue.due_date}\">"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
o << "<script>"
o << "//<![CDATA[\n"
o << " if(typeof datepickerOptions !== 'undefined'){\n"
o << " $(function() { $('#StartDateInput input').addClass('date').datepickerFallback(datepickerOptions); });\n"
o << " }\n"
o << "//]]>\n"
o << "</script>"
end
# Due date # %done dropdown
if(!(readOnlyAttributes.include? 'due_date')) if ! readOnlyAttributes.include?('done_ratio')
o << "<span class='dynamicEdit' id='DueDateInput'>" percent = 0
o << " <input size=\"10\" value=\"#{issue.due_date}\" type=\"date\" min=\"#{issue.start_date}\">" o << "<span class='dynamicEdit' id='doneRatioListDropdown'>"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>" o << "<select data-issue='#{issue_id}'><option disabled='disabled' selected> </option>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>" loop do
o << "</span>" if percent == issue.done_ratio
o << "<script>" o << "<option value='#{percent}' selected>#{percent}%</option>"
o << "//<![CDATA[\n" else
o << " if(typeof datepickerOptions !== 'undefined'){\n" o << "<option value='#{percent}'>#{percent}%</option>"
o << " $(function() { $('#DueDateInput input').addClass('date').datepickerFallback(datepickerOptions); });\n" end
o << " }\n" percent += 10
o << "//]]>\n"
o << "</script>"
end
# Title break if percent == 110
o << "<span class='dynamicEdit' id='TitleInput'>" end
o << " <input size=\"50\" value=\"#{issue.subject}\" type=\"text\">"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
# Description o << "</select> <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></span>"
o << "<span class='dynamicEdit' id='DescriptionInput'>" end
o << " <textarea name='description' id='description_textarea' cols='60' rows='10' style='width:calc(100\% - 10px)'>#{issue.description}</textarea>"
o << " <div style='display:block; text-align:right; margin-top:10px;'><a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></div>"
o << "</span>"
end # Estimated_time dropdown
end if ! readOnlyAttributes.include?('estimated_hours')
o << "<span class='dynamicEdit' id='EstimatedTimeInput'>"
o << " <input type='text' value='#{issue.estimated_hours}' size='6'/>"
o << "<a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
end
o << "<script>" # Start date
if ! readOnlyAttributes.include?('start_date')
o << "<span class='dynamicEdit' id='StartDateInput'>"
o << " <input size=\"10\" value=\"#{issue.start_date}\" type=\"date\" max=\"#{issue.due_date}\">"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
o << "<script>"
o << "//<![CDATA[\n"
o << " if(typeof datepickerOptions !== 'undefined'){\n"
o << " $(function() { $('#StartDateInput input').addClass('date').datepickerFallback(datepickerOptions); });\n"
o << " }\n"
o << "//]]>\n"
o << "</script>"
end
o << " var CF_VALUE_JSON = " + issue.editable_custom_field_values(User.current).to_json + ";\n" # Due date
if ! readOnlyAttributes.include?('due_date')
o << "<span class='dynamicEdit' id='DueDateInput'>"
o << " <input size=\"10\" value=\"#{issue.due_date}\" type=\"date\" min=\"#{issue.start_date}\">"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
o << "<script>"
o << "//<![CDATA[\n"
o << " if(typeof datepickerOptions !== 'undefined'){\n"
o << " $(function() { $('#DueDateInput input').addClass('date').datepickerFallback(datepickerOptions); });\n"
o << " }\n"
o << "//]]>\n"
o << "</script>"
end
o << " var _ISSUE_ID = \"#{issue_id}\";\n" # Title
o << " var _USER_API_KEY = \"#{User.current.api_key}\";\n" o << "<span class='dynamicEdit' id='TitleInput'>"
o << " var _BASE_REDMINE_PATH = \"#{Redmine::Utils.relative_url_root}\";\n" o << " <input size=\"50\" value=\"#{issue.subject}\" type=\"text\">"
o << " <a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a>"
o << "</span>"
# Translations text # Description
o << " var _TXT_VALIDATION_BTN = \"" + l(:ide_txt_validation_btn) + "\";\n" o << "<span class='dynamicEdit' id='DescriptionInput'>"
o << " var _TXT_CANCEL_BTN = \"" + l(:ide_txt_cancel_btn) + "\";\n" o << " <textarea name='description' id='description_textarea' cols='60' rows='10' style='width:calc(100\% - 10px)'>#{issue.description}</textarea>"
o << " var _TXT_ERROR_POSITIVE_NUMBER = \"" + l(:ide_txt_error_positive_number) + "\";\n" o << " <div style='display:block; text-align:right; margin-top:10px;'><a href='#' class='btn btn-primary validate' aria-label='" + l(:ide_txt_validation_btn) + "'><i class='fa fa-check fa-fw' aria-hidden='true'></i></a>"
o << " var _TXT_ERROR_START_DATE = \"" + l(:ide_txt_error_start_date) + "\";\n" o << " <a href='#' class='btn btn-primary close' aria-label='" + l(:ide_txt_cancel_btn) + "'><i class='fa fa-times fa-fw' aria-hidden='true'></i></a></div>"
o << " var _TXT_ERROR_DUE_DATE = \"" + l(:ide_txt_error_due_date) + "\";\n" o << "</span>"
o << " var _TXT_ERROR_AJAX_CALL = \"" + l(:ide_txt_error_ajax_call) + "\";\n" end
o << " var _TXT_REQUIRED_FIELD = \"" + l(:ide_txt_required_field) + "\";\n" end
o << "</script>\n"
o << "<script>"
o << " var CF_VALUE_JSON = " + issue.editable_custom_field_values(User.current).to_json + ";\n"
o << "<div style='display:none' id='required_field_array'>#{requiredAttributes.to_json}</div>\n" o << " var _ISSUE_ID = \"#{issue_id}\";\n"
o << " var _USER_API_KEY = \"#{User.current.api_key}\";\n"
o << " var _BASE_REDMINE_PATH = \"#{Redmine::Utils.relative_url_root}\";\n"
# Translations text
o << " var _TXT_VALIDATION_BTN = \"" + l(:ide_txt_validation_btn) + "\";\n"
o << " var _TXT_CANCEL_BTN = \"" + l(:ide_txt_cancel_btn) + "\";\n"
o << " var _TXT_ERROR_POSITIVE_NUMBER = \"" + l(:ide_txt_error_positive_number) + "\";\n"
o << " var _TXT_ERROR_START_DATE = \"" + l(:ide_txt_error_start_date) + "\";\n"
o << " var _TXT_ERROR_DUE_DATE = \"" + l(:ide_txt_error_due_date) + "\";\n"
o << " var _TXT_ERROR_AJAX_CALL = \"" + l(:ide_txt_error_ajax_call) + "\";\n"
o << " var _TXT_REQUIRED_FIELD = \"" + l(:ide_txt_required_field) + "\";\n"
o << "</script>\n"
# closing the display none div parent o << "<div style='display:none' id='required_field_array'>#{requiredAttributes.to_json}</div>\n"
o << "</div>"
return o # closing the display none div parent
o << "</div>"
return o
end end
end end
end end