From d5448267be07013b591a068c27f0b887cd4f4bf8 Mon Sep 17 00:00:00 2001 From: Karel Picman Date: Tue, 9 Jan 2018 15:38:15 +0100 Subject: [PATCH] Limit revision's description text length --- app/models/dmsf_file_revision.rb | 1 + test/unit/dmsf_file_revision_test.rb | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/app/models/dmsf_file_revision.rb b/app/models/dmsf_file_revision.rb index 0b4d1730..7b56b6cb 100644 --- a/app/models/dmsf_file_revision.rb +++ b/app/models/dmsf_file_revision.rb @@ -55,6 +55,7 @@ class DmsfFileRevision < ActiveRecord::Base validates :title, :presence => true validates_format_of :name, :with => DmsfFolder::INVALID_CHARACTERS, :message => l(:error_contains_invalid_character) + validates :description, length: { maximum: 1.megabyte } def project self.dmsf_file.project if self.dmsf_file diff --git a/test/unit/dmsf_file_revision_test.rb b/test/unit/dmsf_file_revision_test.rb index 71c2b4f1..19e04e30 100644 --- a/test/unit/dmsf_file_revision_test.rb +++ b/test/unit/dmsf_file_revision_test.rb @@ -210,4 +210,11 @@ class DmsfFileRevisionTest < RedmineDmsf::Test::UnitTest assert_equal -(' '.ord), @revision1.minor_version end + def description_max_length + @revision1.description = 2.megabytes * 'a' + assert !@revision1.save + @revision1.description = 1.megabyte * 'a' + assert @revision1.save + end + end \ No newline at end of file