From cf7f67e1fbc4ae62690e35414e0232285076621b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karel=20Pi=C4=8Dman?= <karel.picman@kontron.com>
Date: Tue, 30 Sep 2025 15:20:44 +0200
Subject: [PATCH] Rubocop

---
 .rubocop.yml                                     |  7 +------
 app/validators/dmsf_file_extension_validator.rb  |  4 ++--
 app/validators/dmsf_folder_parent_validator.rb   |  3 +--
 app/validators/dmsf_max_file_size_validator.rb   | 15 ++++++---------
 lib/redmine_dmsf/hooks/views/issue_view_hooks.rb | 10 +++++-----
 test/helper_test.rb                              |  2 +-
 test/integration/webdav/dmsf_webdav_head_test.rb |  1 -
 test/integration/webdav/dmsf_webdav_lock_test.rb |  1 -
 test/integration_test.rb                         |  2 +-
 test/test_case.rb                                |  2 +-
 test/unit_test.rb                                |  2 +-
 11 files changed, 19 insertions(+), 30 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index 770b807d..ff20ea66 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -18,7 +18,6 @@
 AllCops:
   TargetRubyVersion: 3.2
   TargetRailsVersion: 7.1
-
   SuggestExtensions: false
 
   NewCops: enable
@@ -26,10 +25,6 @@ AllCops:
   Exclude:
     - '**/vendor/**/*'
 
-plugins:
-  - rubocop-performance
-  - rubocop-rails
-
 # Rules for DMSF
 Layout/LineLength:
   Exclude:
@@ -81,7 +76,7 @@ Naming/AccessorMethodName:
   Exclude:
     - lib/dav4rack/resource.rb
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   Exclude:
     - patches/attachable_patch.rb
 
diff --git a/app/validators/dmsf_file_extension_validator.rb b/app/validators/dmsf_file_extension_validator.rb
index 898fb14e..7f8cc851 100644
--- a/app/validators/dmsf_file_extension_validator.rb
+++ b/app/validators/dmsf_file_extension_validator.rb
@@ -22,10 +22,10 @@ class DmsfFileExtensionValidator < ActiveModel::EachValidator
   include Redmine::I18n
 
   def validate_each(record, attribute, value)
-    return true unless attribute.to_s == 'name'
+    return unless attribute.to_s == 'name'
 
     extension = File.extname(value)
-    return true if Attachment.valid_extension?(extension)
+    return if Attachment.valid_extension?(extension)
 
     record.errors.add(:base, l(:error_attachment_extension_not_allowed, extension: extension))
   end
diff --git a/app/validators/dmsf_folder_parent_validator.rb b/app/validators/dmsf_folder_parent_validator.rb
index 7056325f..93ba6dfb 100644
--- a/app/validators/dmsf_folder_parent_validator.rb
+++ b/app/validators/dmsf_folder_parent_validator.rb
@@ -25,10 +25,9 @@ class DmsfFolderParentValidator < ActiveModel::EachValidator
     while folder
       if folder == record
         record.errors.add attribute, :invalid
-        return false
+        return
       end
       folder = folder.dmsf_folder
     end
-    true
   end
 end
diff --git a/app/validators/dmsf_max_file_size_validator.rb b/app/validators/dmsf_max_file_size_validator.rb
index 6fc64372..d9c9c470 100644
--- a/app/validators/dmsf_max_file_size_validator.rb
+++ b/app/validators/dmsf_max_file_size_validator.rb
@@ -22,14 +22,11 @@ class DmsfMaxFileSizeValidator < ActiveModel::EachValidator
   include Redmine::I18n
 
   def validate_each(record, attribute, value)
-    if value && (value > Setting.attachment_max_size.to_i.kilobytes)
-      record.errors.add attribute,
-                        l(:error_attachment_too_big, max_size: ActiveSupport::NumberHelper.number_to_human_size(
-                          Setting.attachment_max_size.to_i.kilobytes
-                        ))
-      false
-    else
-      true
-    end
+    return unless value && (value > Setting.attachment_max_size.to_i.kilobytes)
+
+    record.errors.add attribute,
+                      l(:error_attachment_too_big, max_size: ActiveSupport::NumberHelper.number_to_human_size(
+                        Setting.attachment_max_size.to_i.kilobytes
+                      ))
   end
 end
diff --git a/lib/redmine_dmsf/hooks/views/issue_view_hooks.rb b/lib/redmine_dmsf/hooks/views/issue_view_hooks.rb
index 159c1ec7..2d0e8b63 100644
--- a/lib/redmine_dmsf/hooks/views/issue_view_hooks.rb
+++ b/lib/redmine_dmsf/hooks/views/issue_view_hooks.rb
@@ -34,7 +34,7 @@ module RedmineDmsf
           html = +''
           container = context[:container]
           # Radio buttons
-          if allowed_to_attach_documents(container)
+          if allowed_to_attach_documents?(container)
             html << '<p>'
             classes = +'inline'
             html << "<label class=\"#{classes}\">"
@@ -64,7 +64,7 @@ module RedmineDmsf
             end
           end
           # Upload form
-          html << attach_documents_form(context, label: false) if allowed_to_attach_documents(container)
+          html << attach_documents_form(context, label: false) if allowed_to_attach_documents?(container)
           html
         end
 
@@ -94,7 +94,7 @@ module RedmineDmsf
 
         def view_issues_edit_notes_bottom_style(context = {})
           if User.current.pref.dmsf_attachments_upload_choice == 'Attachments' ||
-             !allowed_to_attach_documents(context[:container])
+             !allowed_to_attach_documents?(context[:container])
             ''
           else
             'display: none'
@@ -103,7 +103,7 @@ module RedmineDmsf
 
         private
 
-        def allowed_to_attach_documents(container)
+        def allowed_to_attach_documents?(container)
           return false unless container.respond_to?(:project) && container.respond_to?(:saved_dmsf_attachments) &&
                               RedmineDmsf.dmsf_act_as_attachable?
 
@@ -147,7 +147,7 @@ module RedmineDmsf
 
           # Add Dmsf upload form
           container = context[:container]
-          return unless allowed_to_attach_documents(container)
+          return unless allowed_to_attach_documents?(container)
 
           html = +'<p'
           html << ' style="display: none;"' if User.current.pref.dmsf_attachments_upload_choice == 'Attachments'
diff --git a/test/helper_test.rb b/test/helper_test.rb
index c10dc397..4fb38e94 100644
--- a/test/helper_test.rb
+++ b/test/helper_test.rb
@@ -22,7 +22,7 @@ module RedmineDmsf
     # Helper test
     class HelperTest < ActiveSupport::TestCase
       def initialize(name)
-        super(name)
+        super
         # Load all plugin's fixtures
         dir = File.join(File.dirname(__FILE__), 'fixtures')
         ext = '.yml'
diff --git a/test/integration/webdav/dmsf_webdav_head_test.rb b/test/integration/webdav/dmsf_webdav_head_test.rb
index 5d3861b5..35185ea1 100644
--- a/test/integration/webdav/dmsf_webdav_head_test.rb
+++ b/test/integration/webdav/dmsf_webdav_head_test.rb
@@ -21,7 +21,6 @@ require File.expand_path('../../../test_helper', __FILE__)
 
 # WebDAV HEAD tests
 class DmsfWebdavHeadTest < RedmineDmsf::Test::IntegrationTest
-
   def test_head_requires_authentication
     head "/dmsf/webdav/#{@project1.identifier}"
     assert_response :unauthorized
diff --git a/test/integration/webdav/dmsf_webdav_lock_test.rb b/test/integration/webdav/dmsf_webdav_lock_test.rb
index d58b5fbb..32a21ce4 100644
--- a/test/integration/webdav/dmsf_webdav_lock_test.rb
+++ b/test/integration/webdav/dmsf_webdav_lock_test.rb
@@ -22,7 +22,6 @@ require 'fileutils'
 
 # WebDAV LOCK test
 class DmsfWebdavLockTest < RedmineDmsf::Test::IntegrationTest
-
   def setup
     super
     @xml = %(<?xml version="1.0" encoding="utf-8" ?>
diff --git a/test/integration_test.rb b/test/integration_test.rb
index 38404b44..4b993a9a 100644
--- a/test/integration_test.rb
+++ b/test/integration_test.rb
@@ -22,7 +22,7 @@ module RedmineDmsf
     # Integration test
     class IntegrationTest < Redmine::IntegrationTest
       def initialize(name)
-        super(name)
+        super
         # Load all plugin's fixtures
         dir = File.join(File.dirname(__FILE__), 'fixtures')
         ext = '.yml'
diff --git a/test/test_case.rb b/test/test_case.rb
index b44c3463..32fb5fef 100644
--- a/test/test_case.rb
+++ b/test/test_case.rb
@@ -22,7 +22,7 @@ module RedmineDmsf
     # Test case
     class TestCase < ActionDispatch::IntegrationTest
       def initialize(name)
-        super(name)
+        super
         # Load all plugin's fixtures
         dir = File.join(File.dirname(__FILE__), 'fixtures')
         ext = '.yml'
diff --git a/test/unit_test.rb b/test/unit_test.rb
index cf7f24aa..57365f29 100644
--- a/test/unit_test.rb
+++ b/test/unit_test.rb
@@ -22,7 +22,7 @@ module RedmineDmsf
     # Unit test
     class UnitTest < ActiveSupport::TestCase
       def initialize(name)
-        super(name)
+        super
         # Load all plugin's fixtures
         dir = File.join(File.dirname(__FILE__), 'fixtures')
         ext = '.yml'