-> 404 if a file not found

2014-10-23 14:27:55 +02:00 · 2014-10-23 14:27:55 +02:00 · c4de573768
commit c4de573768
parent f4662a4fd9
1 changed files with 11 additions and 5 deletions
--- a/app/controllers/dmsf_files_controller.rb
+++ b/app/controllers/dmsf_files_controller.rb
@ -33,13 +33,19 @@ class DmsfFilesController < ApplicationController
    @revision = @file.last_revision

    check_project(@revision.file)
-    access = DmsfFileRevisionAccess.new(:user_id => User.current.id, :dmsf_file_revision_id => @revision.id,
+    access = DmsfFileRevisionAccess.new(:user_id => User.current.id, 
+      :dmsf_file_revision_id => @revision.id,
      :action => DmsfFileRevisionAccess::DownloadAction)
    access.save!
-    send_file(@revision.disk_file,
-      :filename => filename_for_content_disposition(@revision.name),
-      :type => @revision.detect_content_type,
-      :disposition => 'inline')
+    begin
+      send_file(@revision.disk_file,
+        :filename => filename_for_content_disposition(@revision.name),
+        :type => @revision.detect_content_type,
+        :disposition => 'inline')
+    rescue ActionController::MissingFile => e
+      logger.error e.message
+      render_404
+    end 
  end

  def show