Javascript defer = true

This commit is contained in:
Karel Picman 2018-03-14 16:07:12 +01:00
parent 7f14c71550
commit a69b2bdad5
5 changed files with 21 additions and 22 deletions

View File

@ -125,8 +125,8 @@
<%= context_menu %> <%= context_menu %>
<% content_for :header_tags do %> <% content_for :header_tags do %>
<%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => 'redmine_dmsf' %> <%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => :redmine_dmsf %>
<%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => 'redmine_dmsf' %> <%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => :redmine_dmsf, defer: true %>
<% title = DmsfFolder.get_column_position('title') %> <% title = DmsfFolder.get_column_position('title') %>
<% position = DmsfFolder.get_column_position('position') %> <% position = DmsfFolder.get_column_position('position') %>

View File

@ -170,8 +170,8 @@
<%= context_menu %> <%= context_menu %>
<% content_for :header_tags do %> <% content_for :header_tags do %>
<%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => 'redmine_dmsf' %> <%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => :redmine_dmsf %>
<%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => 'redmine_dmsf' %> <%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => :redmine_dmsf, defer: true %>
<% title = DmsfFolder.get_column_position('title') %> <% title = DmsfFolder.get_column_position('title') %>
<% position = DmsfFolder.get_column_position('position') %> <% position = DmsfFolder.get_column_position('position') %>

View File

@ -220,6 +220,6 @@
<% end %> <% end %>
<% content_for :header_tags do %> <% content_for :header_tags do %>
<%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => 'redmine_dmsf' %> <%= stylesheet_link_tag 'jquery.dataTables/datatables.min.css', :plugin => :redmine_dmsf %>
<%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => 'redmine_dmsf' %> <%= javascript_include_tag 'jquery.dataTables/datatables.min.js', :plugin => :redmine_dmsf, defer: true %>
<% end %> <% end %>

View File

@ -45,8 +45,7 @@
</div> </div>
<% end %> <% end %>
<%# TODO: late_javascript_tag is not working here %> <%= late_javascript_tag do %>
<%= javascript_tag do %>
var originalUploaderContent; var originalUploaderContent;
var uploader = $('#dmsf_uploader'); var uploader = $('#dmsf_uploader');
originalUploaderContent = uploader.html(); originalUploaderContent = uploader.html();
@ -59,15 +58,15 @@
} }
}); });
initPlUploader(uploader); initPlUploader(uploader);
var dmsfFileFieldCount = 1; window.dmsfFileFieldCount = 1;
<% end %> <% end %>
<% content_for :header_tags do %> <% content_for :header_tags do %>
<%= stylesheet_link_tag 'plupload/jquery.ui.plupload.css', :plugin => 'redmine_dmsf' %> <%= stylesheet_link_tag 'plupload/jquery.ui.plupload.css', :plugin => :redmine_dmsf %>
<%= javascript_include_tag 'plupload/js/plupload.full.min.js', :plugin => 'redmine_dmsf' %> <%= javascript_include_tag 'plupload/js/plupload.full.min.js', :plugin => :redmine_dmsf, defer: true %>
<%= javascript_include_tag 'plupload/js/jquery.ui.plupload/jquery.ui.plupload.js', :plugin => 'redmine_dmsf' %> <%= javascript_include_tag 'plupload/js/jquery.ui.plupload/jquery.ui.plupload.js', :plugin => :redmine_dmsf, defer: true %>
<%= javascript_include_tag(js_url, :plugin => 'redmine_dmsf') %> <%= javascript_include_tag(js_url, :plugin => :redmine_dmsf, defer: true) %>
<%= javascript_tag do %> <%= late_javascript_tag do %>
function initPlUploader(uploader) { function initPlUploader(uploader) {
uploader.html('<div></div>'); uploader.html('<div></div>');
uploader = $('div', uploader); uploader = $('div', uploader);
@ -107,19 +106,19 @@
} else { } else {
if (responseObject.error == null) { if (responseObject.error == null) {
var disk_filename_input = $('<input/>').attr('type', 'hidden') var disk_filename_input = $('<input/>').attr('type', 'hidden')
.attr('name', 'uploaded[' + dmsfFileFieldCount + '][disk_filename]') .attr('name', 'uploaded[' + window.dmsfFileFieldCount + '][disk_filename]')
.val(responseObject.disk_filename); .val(responseObject.disk_filename);
uploader.append(disk_filename_input); uploader.append(disk_filename_input);
var content_type_input = $('<input/>').attr('type', 'hidden') var content_type_input = $('<input/>').attr('type', 'hidden')
.attr('name', 'uploaded[' + dmsfFileFieldCount + '][content_type]') .attr('name', 'uploaded[' + window.dmsfFileFieldCount + '][content_type]')
.val(responseObject.content_type); .val(responseObject.content_type);
uploader.append(content_type_input); uploader.append(content_type_input);
var original_filename_input = $('<input/>').attr('type', 'hidden') var original_filename_input = $('<input/>').attr('type', 'hidden')
.attr('name', 'uploaded[' + dmsfFileFieldCount + '][original_filename]') .attr('name', 'uploaded[' + window.dmsfFileFieldCount + '][original_filename]')
.val(responseObject.original_filename); .val(responseObject.original_filename);
uploader.append(original_filename_input); uploader.append(original_filename_input);
var tempfile_path = $('<input/>').attr('type', 'hidden') var tempfile_path = $('<input/>').attr('type', 'hidden')
.attr('name', 'uploaded[' + dmsfFileFieldCount + '][tempfile_path]') .attr('name', 'uploaded[' + window.dmsfFileFieldCount + '][tempfile_path]')
.val(responseObject.tempfile_path); .val(responseObject.tempfile_path);
uploader.append(tempfile_path); uploader.append(tempfile_path);
} else { } else {
@ -130,7 +129,7 @@
} }
if(pluploader.total.uploaded == pluploader.files.length) $('#uploadform').submit(); if(pluploader.total.uploaded == pluploader.files.length) $('#uploadform').submit();
else if((pluploader.total.uploaded + pluploader.total.failed) == pluploader.files.length) setTimeout(function() {$('#uploadform').submit();}, 2000); else if((pluploader.total.uploaded + pluploader.total.failed) == pluploader.files.length) setTimeout(function() {$('#uploadform').submit();}, 2000);
else dmsfFileFieldCount++; else window.dmsfFileFieldCount++;
return true; return true;
}); });
} }

View File

@ -28,9 +28,9 @@ module RedmineDmsf
return if defined?(EasyExtensions) return if defined?(EasyExtensions)
"\n".html_safe + stylesheet_link_tag('redmine_dmsf.css', :plugin => :redmine_dmsf) + "\n".html_safe + stylesheet_link_tag('redmine_dmsf.css', :plugin => :redmine_dmsf) +
"\n".html_safe + stylesheet_link_tag('select2.min.css', :plugin => :redmine_dmsf) + "\n".html_safe + stylesheet_link_tag('select2.min.css', :plugin => :redmine_dmsf) +
"\n".html_safe + javascript_include_tag('select2.min.js', :plugin => :redmine_dmsf) + "\n".html_safe + javascript_include_tag('select2.min.js', :plugin => :redmine_dmsf, defer: true) +
"\n".html_safe + javascript_include_tag('redmine_dmsf.js', :plugin => :redmine_dmsf) + "\n".html_safe + javascript_include_tag('redmine_dmsf.js', :plugin => :redmine_dmsf, defer: true) +
"\n".html_safe + javascript_include_tag('attachments_dmsf.js', :plugin => :redmine_dmsf) "\n".html_safe + javascript_include_tag('attachments_dmsf.js', :plugin => :redmine_dmsf, defer: true)
end end
def easy_extensions_javascripts_hook(context={}) def easy_extensions_javascripts_hook(context={})