redmine_plugins/redmine_dmsf
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MKCOL request should return 201 instead of 200 when succeeded"

Browse Source
This commit is contained in:
Karel Pičman 2018-05-15 15:05:32 +02:00
parent b641af8ae1
commit 873354ad2c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/redmine_dmsf/webdav/dmsf_resource.rb
View File

@ -175,7 +175,7 @@ module RedmineDmsf
f.dmsf_folder_id = parent_folder f.dmsf_folder_id = parent_folder
f.project = project f.project = project
f.user = User.current f.user = User.current
f.save ? OK : Conflict f.save ? Created : Conflict
else else
UnsupportedMediaType UnsupportedMediaType
end end

4
test/integration/webdav/dmsf_webdav_mkcol_test.rb
View File

@ -103,14 +103,14 @@ class DmsfWebdavMkcolTest < RedmineDmsf::Test::IntegrationTest
@project1.enable_module! :dmsf @project1.enable_module! :dmsf
@role.add_permission! :folder_manipulation @role.add_permission! :folder_manipulation
xml_http_request :mkcol, "/dmsf/webdav/#{@project1.identifier}/test1", nil, @jsmith xml_http_request :mkcol, "/dmsf/webdav/#{@project1.identifier}/test1", nil, @jsmith
assert_response :success assert_response 201 # Created
Setting.plugin_redmine_dmsf['dmsf_webdav_use_project_names'] = true Setting.plugin_redmine_dmsf['dmsf_webdav_use_project_names'] = true
if Setting.plugin_redmine_dmsf['dmsf_webdav_use_project_names'] == true if Setting.plugin_redmine_dmsf['dmsf_webdav_use_project_names'] == true
project1_uri = Addressable::URI.escape(RedmineDmsf::Webdav::ProjectResource.create_project_name(@project1)) project1_uri = Addressable::URI.escape(RedmineDmsf::Webdav::ProjectResource.create_project_name(@project1))
xml_http_request :mkcol, "/dmsf/webdav/#{@project1.identifier}/test2", nil, @jsmith xml_http_request :mkcol, "/dmsf/webdav/#{@project1.identifier}/test2", nil, @jsmith
assert_response 404 assert_response 404
xml_http_request :mkcol, "/dmsf/webdav/#{project1_uri}/test3", nil, @jsmith xml_http_request :mkcol, "/dmsf/webdav/#{project1_uri}/test3", nil, @jsmith
assert_response :success assert_response 201 # Created
end end
end end
end end