From 43c7348a71550c884978751b371f2ce3af4f51ae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karel=20Pi=C4=8Dman?= Date: Fri, 18 Sep 2015 10:33:13 +0200 Subject: [PATCH] Internal error when creating a new workflow #446 --- app/controllers/dmsf_workflows_controller.rb | 3 ++- app/models/dmsf_workflow.rb | 4 +--- test/unit/dmsf_workflow_test.rb | 3 ++- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/controllers/dmsf_workflows_controller.rb b/app/controllers/dmsf_workflows_controller.rb index d2b10192..a7b213b1 100644 --- a/app/controllers/dmsf_workflows_controller.rb +++ b/app/controllers/dmsf_workflows_controller.rb @@ -221,7 +221,8 @@ class DmsfWorkflowsController < ApplicationController wf = DmsfWorkflow.find_by_id params[:dmsf_workflow_id] @dmsf_workflow = wf.copy_to(@project, params[:dmsf_workflow][:name]) if wf else - @dmsf_workflow = DmsfWorkflow.new(:name => params[:dmsf_workflow][:name]) + @dmsf_workflow = DmsfWorkflow.new + @dmsf_workflow.name = params[:dmsf_workflow][:name] @dmsf_workflow.project_id = @project.id if @project @dmsf_workflow.save end diff --git a/app/models/dmsf_workflow.rb b/app/models/dmsf_workflow.rb index a29da4ba..6bf6393c 100644 --- a/app/models/dmsf_workflow.rb +++ b/app/models/dmsf_workflow.rb @@ -21,9 +21,7 @@ class DmsfWorkflow < ActiveRecord::Base has_many :dmsf_workflow_steps, -> { order 'step ASC, operator DESC' }, :dependent => :destroy - - attr_accessible :name - + scope :sorted, lambda { order('name ASC') } scope :global, lambda { where('project_id IS NULL') } diff --git a/test/unit/dmsf_workflow_test.rb b/test/unit/dmsf_workflow_test.rb index 251af6b0..1e2bf580 100644 --- a/test/unit/dmsf_workflow_test.rb +++ b/test/unit/dmsf_workflow_test.rb @@ -58,7 +58,8 @@ class DmsfWorkflowTest < RedmineDmsf::Test::UnitTest end def test_create - workflow = DmsfWorkflow.new(:name => 'wf') + workflow = DmsfWorkflow.new + workflow.name = 'wf' assert workflow.save end