redmine_plugins/redmine_custom_workflows
1
0
Fork 0
mirror of https://github.com/anteo/redmine_custom_workflows.git synced 2026-01-26 00:04:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Internal error 500 #281

Browse Source
This commit is contained in:
Karel Pičman 2022-09-20 14:06:01 +02:00
parent 9f874424bc
commit e38829bf2d
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/custom_workflows_controller.rb
View File

@ -88,7 +88,7 @@ class CustomWorkflowsController < ApplicationController
else
flash[:error] = @workflow.errors.full_messages.to_sentence
end
rescue => e
rescue Exception => e
Rails.logger.warn "Workflow import error: #{e.message}\n #{e.backtrace.join("\n ")}"
flash[:error] = l(:error_failed_import)
end

4
app/models/custom_workflow.rb
View File

@ -98,7 +98,7 @@ class CustomWorkflow < ActiveRecord::Base
Rails.logger.info "== User workflow error: #{e.message}"
object.errors.add :base, e.error
false
rescue => e
rescue Exception => e
Rails.logger.error "== Custom workflow exception: #{e.message}\n #{e.backtrace.join("\n ")}"
object.errors.add :base, :custom_workflow_error
false
@ -111,7 +111,7 @@ class CustomWorkflow < ActiveRecord::Base
def validate_syntax_for(object, event)
object.instance_eval(read_attribute(event)) if respond_to?(event) && read_attribute(event)
rescue RedmineCustomWorkflows::Errors::WorkflowError => _
rescue => e
rescue Exception => e
errors.add event, :invalid_script, error: e
end