Redmine 4.1 compatibility

Gemfile

@@ -26,5 +26,5 @@ gem 'activemodel-serializers-xml'
 
 # Redmine extensions
 unless %w(easyproject easy_gantt).any? { |plugin| Dir.exist?(File.expand_path("../../#{plugin}", __FILE__)) }
-  gem 'redmine_extensions', '~> 0.2.5'
+  gem 'redmine_extensions', '~> 0.3.9'
 end

after_init.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

app/controllers/custom_workflows_controller.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #
@@ -50,14 +51,14 @@ class CustomWorkflowsController < ApplicationController
   end
 
   def index
-    @workflows = CustomWorkflow.includes(:projects).order(:position => :asc)
+    @workflows = CustomWorkflow.includes(:projects).order(position: :asc)
     respond_to do |format|
       format.html
     end
   end
 
   def export
-    send_data @workflow.export_as_xml, :filename => @workflow.name + '.xml', :type => :xml
+    send_data @workflow.export_as_xml, filename: "#{@workflow.name}.xml", type: :xml
   end
 
   def show
@@ -87,7 +88,7 @@ class CustomWorkflowsController < ApplicationController
       else
         flash[:errors] = @workflow.errors.full_messages.to_sentence
       end
-    rescue Exception => e
+    rescue => e
       Rails.logger.warn "Workflow import error: #{e.message}\n #{e.backtrace.join("\n ")}"
       flash[:errors] = l(:error_failed_import)
     end

app/models/custom_workflow.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #
@@ -50,7 +51,7 @@ class CustomWorkflow < ActiveRecord::Base
   end
 
   def self.log_message(str, object)
-    Rails.logger.info str + " for #{object.class} (\##{object.id}) \"#{object}\""
+    Rails.logger.info "#{str} for #{object.class} (\##{object.id}) \"#{object}\""
   end
 
   def self.run_shared_code(object)
@@ -96,7 +97,7 @@ class CustomWorkflow < ActiveRecord::Base
     Rails.logger.info "== User workflow error: #{e.message}"
     object.errors.add :base, e.error
     false
-  rescue Exception => e
+  rescue => e
     Rails.logger.error "== Custom workflow exception: #{e.message}\n #{e.backtrace.join("\n ")}"
     object.errors.add :base, :custom_workflow_error
     false
@@ -109,7 +110,7 @@ class CustomWorkflow < ActiveRecord::Base
   def validate_syntax_for(object, event)
     object.instance_eval(read_attribute(event)) if respond_to?(event) && read_attribute(event)
   rescue WorkflowError => _
-  rescue Exception => e
+  rescue => e
     errors.add event, :invalid_script, error: e
   end
 

app/models/custom_workflow_mailer.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

config/routes.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

init.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/errors/workflow_error.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #
@@ -23,7 +24,7 @@ class WorkflowError < StandardError
   attr_accessor :error
 
   def initialize(message)
-    @error = message.dup
+    @error = message
     super message
   end
 end

lib/redmine_custom_workflows/hooks/hooks.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/attachment_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/group_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/issue_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/mailer_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/project_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/projects_helper_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/time_entry_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/user_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/version_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/wiki_content_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/patches/wiki_page_patch.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/test/test_case.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

lib/redmine_custom_workflows/test/unit_test.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

test/ci/redmine_install.sh

@@ -21,7 +21,7 @@
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 
 export REDMINE_GIT_REPO=git://github.com/redmine/redmine.git
-export REDMINE_GIT_TAG=4.0-stable
+export REDMINE_GIT_TAG=4.1-stable
 
 clone()
 {

test/fixtures/custom_workflows.yml

@@ -4,7 +4,7 @@ custom_workflows_001:
   before_save:    "Rails.logger.info '>>> before save'"
   after_save:     "Rails.logger.info '>>> after save'"
   name:           'Issue CW test'
-  description:    NULL
+  description:    'Testing workflow'
   position:       1
   is_for_all:     0
   author:         'karel.picman@kontron.com'

test/functional/custom_workflows_controller_test.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

test/test_helper.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

test/unit/custom_workflow_mailer_test.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

test/unit/custom_workflow_test.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #

test/unit_test.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# frozen_string_literal: true
 #
 # Redmine plugin for Custom Workflows
 #