#116 raise errors

app/models/custom_workflow.rb

@@ -116,7 +116,7 @@ class CustomWorkflow < ActiveRecord::Base
     object.instance_eval(read_attribute(event)) if respond_to?(event) && read_attribute(event)
   rescue WorkflowError => _
   rescue Exception => e
-    errors.add event, :invalid_script, :errors => e
+    errors.add event, :invalid_script, error: e
   end
 
   def validate_scripts_presence

lib/redmine_custom_workflows/patches/attachment_patch.rb

@@ -40,6 +40,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:attachment, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/group_patch.rb

@@ -54,6 +54,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:group, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/issue_patch.rb

@@ -68,6 +68,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:issue, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/project_patch.rb

@@ -59,6 +59,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:project, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/time_entry_patch.rb

@@ -40,6 +40,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:time_entry, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/user_patch.rb

@@ -40,6 +40,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:user, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/version_patch.rb

@@ -40,6 +40,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:version, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil

lib/redmine_custom_workflows/patches/wiki_content_patch.rb

@@ -40,6 +40,7 @@ module RedmineCustomWorkflows
           @saved_attributes = attributes.dup
           CustomWorkflow.run_shared_code(self)
           CustomWorkflow.run_custom_workflows(:wiki_content, self, :before_save)
+          throw :abort if errors.any?
           errors.empty? && (@saved_attributes == attributes || valid?)
         ensure
           @saved_attributes = nil